186526
/
unpkg
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix failing test

This commit is contained in:
MICHAEL JACKSON 2017-08-12 09:40:53 -07:00
parent 99c1f7098a
commit 4653ee9e42
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
server/PackageURL.js
View File

@ -3,11 +3,15 @@ const url = require('url')
const URLFormat = /^\/((?:@[^\/@]+\/)?[^\/@]+)(?:@([^\/]+))?(\/.*)?$/
function decodeParam(param) {
try {
return decodeURIComponent(param)
} catch (error) {
return null
if (param) {
try {
return decodeURIComponent(param)
} catch (error) {
// Ignore invalid params.
}
}
return ''
}
function parsePackageURL(packageURL) {

6
server/PackageURL.test.js
View File

@ -1,4 +1,4 @@
const { parsePackageURL } = require('./PackageURL').parse
const parsePackageURL = require('./PackageURL').parse
describe('parsePackageURL', () => {
it('parses plain packages', () => {
@ -81,8 +81,4 @@ describe('parsePackageURL', () => {
it('returns null for invalid pathnames', () => {
expect(parsePackageURL('history')).toBe(null)
})
it('returns null for invalid query parameters', () => {
expect(parsePackageURL('/query-string@5.0.0/index.js?invalid')).toBe(null)
})
})