186526/unpkg
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove "immutable" from long-term responses

Browse Source 
We had a bug recently which sent out some bad "immutable" responses. We
need to have a better process around cutting releases before we can be
sure it doesn't happen again.
This commit is contained in:
Michael Jackson
2019-01-06 21:10:18 -08:00
parent e4d6df255e
commit d6fde9fb33
6 changed files with 23 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/actions/serveHTMLModule.js
View File

@ -20,7 +20,7 @@ function serveHTMLModule(req, res) {
.set({
'Content-Length': Buffer.byteLength(code),
'Content-Type': getContentTypeHeader(req.entry.contentType),
'Cache-Control': 'public, max-age=31536000, immutable', // 1 year
'Cache-Control': 'public, max-age=31536000', // 1 year
ETag: etag(code),
'Cache-Tag': 'file, html-file, html-module'
})

2
modules/actions/serveJavaScriptModule.js
View File

@ -14,7 +14,7 @@ function serveJavaScriptModule(req, res) {
.set({
'Content-Length': Buffer.byteLength(code),
'Content-Type': getContentTypeHeader(req.entry.contentType),
'Cache-Control': 'public, max-age=31536000, immutable', // 1 year
'Cache-Control': 'public, max-age=31536000', // 1 year
ETag: etag(code),
'Cache-Tag': 'file, js-file, js-module'
})

2
modules/actions/serveMetadata.js
View File

@ -35,7 +35,7 @@ function serveMetadata(req, res) {
res
.set({
'Cache-Control': 'public, max-age=31536000, immutable', // 1 year
'Cache-Control': 'public, max-age=31536000', // 1 year
'Cache-Tag': 'meta'
})
.send(metadata);

2
modules/actions/serveStaticFile.js
View File

@ -15,7 +15,7 @@ function serveStaticFile(req, res) {
.set({
'Content-Length': req.entry.size,
'Content-Type': getContentTypeHeader(req.entry.contentType),
'Cache-Control': 'public, max-age=31536000, immutable', // 1 year
'Cache-Control': 'public, max-age=31536000', // 1 year
'Last-Modified': req.entry.lastModified,
ETag: etag(req.entry.content),
'Cache-Tag': tags.join(', ')