186526
/
unpkg
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Be explicit with status codes

This commit is contained in:
MICHAEL JACKSON 2017-08-22 18:44:26 -07:00
parent eecbfb65f8
commit ab3e21b8f8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/middleware/fetchFile.js
View File

@ -137,7 +137,7 @@ function fetchFile(req, res, next) {
res.set({ res.set({
'Cache-Control': 'public, max-age=60', 'Cache-Control': 'public, max-age=60',
'Cache-Tag': 'redirect' 'Cache-Tag': 'redirect'
}).redirect(createPackageURL(req.packageName, tags[req.packageVersion], req.filename, req.search)) }).redirect(302, createPackageURL(req.packageName, tags[req.packageVersion], req.filename, req.search))
} else { } else {
const maxVersion = semver.maxSatisfying(Object.keys(versions), req.packageVersion) const maxVersion = semver.maxSatisfying(Object.keys(versions), req.packageVersion)
@ -146,7 +146,7 @@ function fetchFile(req, res, next) {
res.set({ res.set({
'Cache-Control': 'public, max-age=60', 'Cache-Control': 'public, max-age=60',
'Cache-Tag': 'redirect' 'Cache-Tag': 'redirect'
}).redirect(createPackageURL(req.packageName, maxVersion, req.filename, req.search)) }).redirect(302, createPackageURL(req.packageName, maxVersion, req.filename, req.search))
} else { } else {
res.status(404).type('text').send(`Cannot find package ${req.packageSpec}`) res.status(404).type('text').send(`Cannot find package ${req.packageSpec}`)
} }