Add tests for undefined query params

Fixes #169
2019-07-30 15:51:14 -07:00
parent 699b849914
commit 7582c641fb
2 changed files with 10 additions and 3 deletions
--- a/modules/utils/createSearch.js
+++ b/modules/utils/createSearch.js
@ -1,12 +1,14 @@
 export default function createSearch(query) {
  const keys = Object.keys(query).sort();
-  const params = keys.reduce(
+  const pairs = keys.reduce(
    (memo, key) =>
      memo.concat(
-        query[key] ? `${key}=${encodeURIComponent(query[key])}` : key
+        query[key] == null || query[key] === ''
+          ? key
+          : `${key}=${encodeURIComponent(query[key])}`
      ),
    []
  );

-  return params.length ? `?${params.join('&')}` : '';
+  return pairs.length ? `?${pairs.join('&')}` : '';
 }