From 124fead8ff7d6af08da6c397a6f384e477953644 Mon Sep 17 00:00:00 2001 From: MICHAEL JACKSON Date: Fri, 1 Sep 2017 20:29:49 -0700 Subject: [PATCH] Do not use ?main fields that are not strings Fixes #62 --- server/middleware/fetchFile.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/server/middleware/fetchFile.js b/server/middleware/fetchFile.js index 73af2ef..dbedeb1 100644 --- a/server/middleware/fetchFile.js +++ b/server/middleware/fetchFile.js @@ -88,10 +88,7 @@ function fetchFile(req, res, next) { // They are requesting an explicit filename. Only try to find an // index file if they are NOT requesting an HTML directory listing. useIndex = filename[filename.length - 1] !== '/' - } else if (req.query.main) { - if (!(req.query.main in req.packageConfig)) - return res.status(404).type('text').send(`Cannot find field "${req.query.main}" in ${req.packageSpec} package config`) - + } else if (req.query.main && typeof req.packageConfig[req.query.main] === 'string') { // They specified a custom ?main field. filename = req.packageConfig[req.query.main] } else if (typeof req.packageConfig.unpkg === 'string') {